-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add missing date-time format to time fields #655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little nitpick, can you have the null
as the last value in the oneOf
s.
It would avoid having to rebuild the types
a3403d7
to
68d5d3b
Compare
Of course @wolfy1339. Sorry about that oversight. Should be fixed now. |
By the way should I rename the PR to get a |
68d5d3b
to
4f1c165
Compare
@wolfy1339 I don't think this changes anything for typescript though, other than https://github.com/octokit/webhooks/pull/655/files#diff-1680c176c64b33118d8088f64fbd82ff896d471c6d18e1d9911ef9aa695c7b0eL3429, right? I just ask because you added the |
4f1c165
to
a7cf195
Compare
It's fine, we can change it if needed when we merge the PR
That would be correct.
I didn't label this PR, you did 😆 |
Ah no, not me either, it was @gr2m. 😆 I did just fix the linting issue. Apologies again, first time contributing to the project need to get the specifics right. |
a7cf195
to
7f39964
Compare
No worries! You're doing just fine for a first time with this project |
Thank you both @wolfy1339 and @gr2m for getting this merged. 🙂 |
🎉 This PR is included in version 6.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
While doing some parsing & codegen work based on the JSON specs I realised that some time-based fields were missing the
date-time
format validation which is a very nice-to-have when dealing with unmarshalling into typed languages.This PR's changes solely focus on adding those missing format hints.