Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for Base UI? #6

Open
oliviertassinari opened this issue Dec 21, 2024 · 2 comments
Open

Feedback for Base UI? #6

oliviertassinari opened this issue Dec 21, 2024 · 2 comments

Comments

@oliviertassinari
Copy link

oliviertassinari commented Dec 21, 2024

Hi, cool project, I love to see this. It's interesting to see the progress here!

Looking at the code, I imagine this started as a fork of https://github.com/shadcn-ui/ui. Which I found interesting because it means that to support Base UI, you effectively have to migrate from the Radix Primitives.

We care a lot about the migration experience from the Radix Primitives. For example, even considered adding deprecated props to help mui/base-ui#601. So I would be very curious to get a sense of the main friction when migrating.

We aim to make Base UI a no-brainer path for Shadcn UI to migrate to (but realistically, it's too early for them to make sense). If the only outcome of this project is to clear the way, ahead of time to smooth things 💡, it's already a big win.

@okmr-d
Copy link
Owner

okmr-d commented Dec 27, 2024

@oliviertassinari
Thanks for looking at this project. This project started as a fork of shadcn/ui.

The migration process is going very well, except for the animations. (But I can easily solve this problem by reading the documentation.)

The other thing that is a bit cumbersome is that Content is now divided into Positioner and Popup, but I think this is a better design for implementing complex positioning.

I will let you know if I notice anything.
Thanks for the Base UI project! 🙏

@oliviertassinari
Copy link
Author

@okmr-d Ok thanks, I have referenced the feedback in an issue. Appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants