Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cropping full width slices #741

Merged
merged 2 commits into from
Sep 3, 2019
Merged

Fix cropping full width slices #741

merged 2 commits into from
Sep 3, 2019

Conversation

NiGhTTraX
Copy link
Contributor

What's Changing and Why

Fixes #675.

What else might be affected

Changes are limited to the crop plugin.

Tasks

  • Add tests: I've added a few tests that check cropping full width/height slices from various starting positions. It doesn't cover the entire crop plugin but I think it's a good start.
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label - should I bump the patch version?

@hipstersmoothie
Copy link
Collaborator

@NiGhTTraX please rebase so the CI runs

@NiGhTTraX
Copy link
Contributor Author

@hipstersmoothie done

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Sep 3, 2019
@hipstersmoothie hipstersmoothie merged commit a4ba612 into jimp-dev:master Sep 3, 2019
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v0.6.6 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Sep 3, 2019
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crop() works incorrectly when x = 0 and w = current image width
2 participants
@NiGhTTraX @hipstersmoothie