Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #745 Tyepscript definition wrong return type on hash() #746

Merged
merged 2 commits into from
Aug 17, 2019
Merged

Fix: #745 Tyepscript definition wrong return type on hash() #746

merged 2 commits into from
Aug 17, 2019

Conversation

soimy
Copy link
Contributor

@soimy soimy commented Jun 4, 2019 •
edited by hipstersmoothie
Loading

What's Changing and Why

According to #745, jimp.d.ts is having wrong return type this on hash(), which should be string
This PR fixed this.

What else might be affected

Nothing

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label

closes #745

@hipstersmoothie hipstersmoothie merged commit a4a8196 into jimp-dev:master Aug 17, 2019
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v0.6.5 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript definition - Wrong hash() return type
2 participants
@soimy @hipstersmoothie