-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include Addition (Add) blending mode + Officially drop support for Node 8 #904
Conversation
No clue why it's failing on node8. It says the GIF export reached a timeout but I don't think that's my fault as every other check passed... Maybe this is what the commits meant by "browser version being broken"? |
You can drop the node 8 config. we can officially drop support with this PR |
packages/core/package.json
Outdated
"access": "public" | ||
} | ||
} | ||
"name": "@jimp/core", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert changes to this file please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix the package.json and this is good to merge
This good? |
@GlitchyPSIX Perfect! No worries, not all repos have their releases automated in the same way jimp does (using https://github.com/intuit/auto) |
🚀 PR was released in |
What's Changing and Why
Addition mode is being... added to the list of compositing modes. Minor change (new feature), fulfills the old request from #724 because I also needed it)
What else might be affected
Nothing else in the
core
package should be affected.Tasks
jimp.d.ts
📦 Published PR as canary version:
0.14.0-canary.904.976.0
✨ Test out this PR locally via: