Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ONLY_SEND_ERRORS option, to only forward Flux errors. #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add the ONLY_SEND_ERRORS option, to only forward Flux errors. #56

wants to merge 1 commit into from

Conversation

Neki
Copy link

@Neki Neki commented Jan 29, 2020

Closes #43

Please let me know if there's something missing in this PR!

@oliviabarrick
Copy link
Owner

Welcome @Neki! It looks like this is your first PR to justinbarrick/fluxcloud 🎉

@oliviabarrick oliviabarrick self-requested a review January 29, 2020 18:18
@oliviabarrick
Copy link
Owner

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Neki
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: justinbarrick

If they are not already assigned, you can assign the PR to them by writing /assign @justinbarrick in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oliviabarrick
Copy link
Owner

Hi @Neki. Thanks for your PR.

I'm waiting for a justinbarrick member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviabarrick oliviabarrick Awaiting requested review from oliviabarrick

Assignees
No one assigned
Labels
needs-ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only send a notification when there is an error
2 participants
@Neki @oliviabarrick