Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google OpenID Connect #477

Closed
fredericcambon opened this issue Jan 6, 2015 · 4 comments
Closed

Google OpenID Connect #477

fredericcambon opened this issue Jan 6, 2015 · 4 comments

Comments

@fredericcambon
Copy link

The backend for Google OpenID Connect (https://github.com/omab/python-social-auth/blob/master/social/backends/google.py#L207) do not match the documentation (https://developers.google.com/accounts/docs/OpenIDConnect)
Indeed, Google OpenID Connect do not support yet 'nonce' param, and extra steps are required to validate an id token (https://developers.google.com/accounts/docs/OpenIDConnect#validatinganidtoken)

=> Google OpenID Connect do not match exactly the specification for OpenID Connect (http://openid.net/specs/openid-connect-core-1_0.html) and its implementation in python-social-auth does not work such as it is now (at least for me)

Has anyone else tried to use it ?

The errors :

With the deprecation of Google OpenID approaching (https://developers.google.com/accounts/docs/OpenID) I suppose some people will have to migrate to OpenID Connect or Google+.

@ebpetway
Copy link

I'm running into the same issue, as I was hoping to use OpenID Connect instead of having to rely on the user having a Google+ account.

Edit: Just read that the user actually doesn't even need a Google+ account if you just use the "profile" scope.
Source: https://developers.google.com/+/api/auth-migration

@eshellman
Copy link
Contributor

I couldn't get Google Open ID Connect to work, I just couldn't shake the AuthCanceled exception on auth-complete. using the Google OAuth2 backend seems to be the right way to replace Google OpenID

@domino14
Copy link

So this doesn't work? We gotta use Google OAuth2 backend?

@omab
Copy link
Owner

omab commented Dec 27, 2016

The related PRs to properly fix Google OpenId Connect were merged or ported to social-core.

@omab omab closed this as completed Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants