-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails with last version of Crystal (Version 0.35.0) #1235
Comments
Feel free to submit a pull request |
I just run into the same issue. I did apply the patch from @DaarkMoon:
Then I have modified
into (because it is the current commit for v0.35.0)
So far so good, but if I run P.S.: It would be good to put that a little more prominent place, because you can easily overlook the last hidden part (
|
Should be fixed with d30a972. |
Great timing.. I was just attempting to install it. Confirmed build is fixed - latest commit builds with no errors! |
Can't get it to build using Docker on master. Using protodec (0.1.3) In src/invidious.cr:26:1 26 | require "compress/zip" If you're trying to require a shard:
|
Build fails when builded with the crystal version 0.35.0 (published on june 09th 2020). This version have some breaking change (see changelog).
I use last version of crystal provided by https://dist.crystal-lang.org/apt for debian (as required in README).
Issue seems to only come from this breaking change (see Files section of crystal 0.35.0 changelog).
This issue also affect the dependancy kemal (but there is an correction)
here a patch that work on my system it's only support crystal 0.35.0. For support of 0.34.0 and 0.35.0 there is an interessing solution in kemal source code)
The text was updated successfully, but these errors were encountered: