Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDE: Fix error in creation of fields from objectDef #186

Merged
merged 7 commits into from
Jan 25, 2021

Conversation

sukunis
Copy link
Member

@sukunis sukunis commented Jan 13, 2021

Call getChildsByType returned an empty array, but caller expected NULL if no child was found. Fixed by return NULL or not empty list.

@snoopycrimecop
Copy link
Member

Empty PR description. Please add a short summary of the PR scope and some testing instructions.

1 similar comment
@snoopycrimecop
Copy link
Member

Empty PR description. Please add a short summary of the PR scope and some testing instructions.

sukunis added 3 commits January 18, 2021 15:58
…-insight into fix_ObjectDefNames

# Conflicts:
#	src/main/java/org/openmicroscopy/shoola/agents/fsimporter/mde/components/view/ModuleTree.java
@dominikl
Copy link
Member

👍 Looks good to me.

@jburel jburel merged commit c6a5e8e into ome:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants