Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metamask popup #151

Closed
pashagonchar opened this issue Nov 27, 2018 · 5 comments
Closed

Update metamask popup #151

pashagonchar opened this issue Nov 27, 2018 · 5 comments
Assignees

Comments

@pashagonchar
Copy link

Old view

image 2018-11-27 at 2 43 14 pm

New view

poa_bridge_popup_nw_mm

Zeplin: https://zpl.io/a8P3Bjx

@igorbarinov
Copy link
Member

@akolotov please assign the issue

@akolotov
Copy link
Collaborator

@fernandomg could you take a look?

@akolotov
Copy link
Collaborator

Open questions and recommendation can be found in #147

@fernandomg fernandomg self-assigned this Nov 28, 2018
@fernandomg
Copy link

Just want to clarify and maybe have a better UX.

Currently the modal with the 'Error' is being displayed despite if the wallet is not installed or locked. The message is quite generic and may lead to confusion.

I can identify each type of error and display:

  • the 'Metamask/Nifty' wallet modal when there's no wallet installed,
  • and the 'Error' modal with a message asking the user to unlock his/her wallet.

Both errors are triggered already, but just need to be properly handled.


Screenshots (check the console error message displayed at the bottom)

Unlock

image

Install

image

Any thoughts @akolotov @igorbarinov?

@akolotov
Copy link
Collaborator

My bid is that we need to handle these two cases in different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants