New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version from submission XML is not used to set submission version #1018

Closed

ukanga opened this issue May 15, 2017 · 0 comments · Fixed by #1021

Labels

Error Module: Submissions Size: Small (≤1)

Member

ukanga commented May 15, 2017 •

edited by imkingrobi

Loading

Seems we use the current xform.version when setting submission version, we should pick the correct version from the XML, affects also the version saved in the JSON data.
https://github.com/onaio/onadata/blob/master/onadata/apps/logger/models/instance.py#L454

    self.version = self.xform.version

Aha! Link: https://ona.aha.io/features/PROD-571

ukanga added Error Module: Submissions Size: Small (≤1) labels

ukanga mentioned this issue

Save correct submission xform version #1021

Merged

ukanga closed this as completed in #1021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment