BUG: main schematic rule usage

[neodmy]

Description

I've noticed we might not be implementing the main schematic rule properly. TypeScript throws a type error. Fortunately, I believe it doesn't have an impact on functionality, and the schematics work.

Expected Behavior

The return should yield a Rule

export function main(options: Options): Rule {
	return (_tree: Tree, context: SchematicContext): Rule => {
		context.logger.info('Creating .nvmrc file and updating package.json...');

		const templateSource = apply(url('./files'), [
			template({...options}),
			move(normalize(options.directory)),
		]);

		return chain([
			mergeWith(templateSource, MergeStrategy.Overwrite),
			updatePackageJson(options),
		]);
	};
}

Actual Behavior

export function main(options: Options): Rule {
	return (tree: Tree, context: SchematicContext): Rule => {
		context.logger.info('Creating .nvmrc file and updating package.json...');

		const templateSource = apply(url('./files'), [
			template({...options}),
			move(normalize(options.directory)),
		]);

		return chain([
			mergeWith(templateSource, MergeStrategy.Overwrite),
			updatePackageJson(options),
		])(tree, context); // no need for calling the second function
	};
}

Possible Fix

Return the result of the schematics function used (which in turn returns a Rule; e.g. mergeWith, chain, etc)