Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computation limit exceeding errors are treated as internal errors #2682

Closed
SupunS opened this issue Jul 26, 2023 · 2 comments · Fixed by #2683
Closed

Computation limit exceeding errors are treated as internal errors #2682

SupunS opened this issue Jul 26, 2023 · 2 comments · Fixed by #2683
Assignees
Labels
Bug Something isn't working Feedback

Comments

@SupunS
Copy link
Member

SupunS commented Jul 26, 2023

Current Behavior

If the user exceeds the computation limit, it should be a user error. But currently it is treated as an internal error (and prints the go-stacktrace). e.g: #2679

Expected Behavior

Such errors should be treated as user errors

Steps To Reproduce

Run a transaction/code that exceeds the computation limit.

Environment

- Cadence version: latest/master
- Network: TN/MN
@SupunS SupunS added Bug Something isn't working Feedback labels Jul 26, 2023
@bluesign
Copy link
Contributor

There are many places this is happening, I think best to solve would be generate a list of errors from transaction results and fix them all in a single PR.

@SupunS
Copy link
Member Author

SupunS commented Jul 27, 2023

Yeah, this needed to be done for all calls to FVM from cadence. Fixed in #2683.

The panicked errors were already handled, but the returned errors were not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants