-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fungible Token should have a name parameterr? #12
Comments
We could add it to the interface, but it isn't the kind of metadata solution that we want, we'd like to have more sophisticated metadata on our token contracts, but haven't come up with the solution yet. see this issue for more context |
Maybe I'm not reading @rahul-kothari point properly but reading the cadence code I see
I do find that if your project includes one NFT then it's all fine if the resource HAS TO bear the name NFT. But as soon as you need 2 distinct NFTs in a single project, then what are we left with to differentiate them with ? Also, if the concrete resource HAS TO be named NFT, then it's not easy to read versus say |
My issue is for fungible tokens and not NFTs :)
… Am 09/03/2021 um 22:37 schrieb Olivier Milla ***@***.***>:
Maybe I'm not reading @rahul-kothari point properly but reading the cadence code I see
Their [New NFT Contract] contract would have to follow all the rules and naming that the interface specifies.
I do find that if your project includes one NFT then it's all fine if the resource HAS TO bear the name NFT. But as soon as you need 2 distinct NFTs in a single project, then what are we left with to differentiate them with ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
sorry my bad, wrong repo :) the "n" is indeed not there ;) |
Issue To Be Solved
Usually, tokens have a
name
parameter along withdecimals
andtotalSupply
.Should this be added to the interface?
The text was updated successfully, but these errors were encountered: