Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fungible Token should have a name parameterr? #12

Closed
rahul-kothari opened this issue May 15, 2020 · 4 comments
Closed

Fungible Token should have a name parameterr? #12

rahul-kothari opened this issue May 15, 2020 · 4 comments
Labels
Feedback P-Low question Further information is requested

Comments

@rahul-kothari
Copy link

Issue To Be Solved

Usually, tokens have a name parameter along with decimals and totalSupply.

Should this be added to the interface?

@joshuahannan
Copy link
Member

We could add it to the interface, but it isn't the kind of metadata solution that we want, we'd like to have more sophisticated metadata on our token contracts, but haven't come up with the solution yet. see this issue for more context

@joshuahannan joshuahannan added Feedback P-Low question Further information is requested labels Jul 20, 2020
@oliviermilla
Copy link

oliviermilla commented Mar 9, 2021

Maybe I'm not reading @rahul-kothari point properly but reading the cadence code I see

Their [New NFT Contract] contract would have to follow all the rules and naming that the interface specifies.

I do find that if your project includes one NFT then it's all fine if the resource HAS TO bear the name NFT. But as soon as you need 2 distinct NFTs in a single project, then what are we left with to differentiate them with ?

Also, if the concrete resource HAS TO be named NFT, then it's not easy to read versus say Cat : NonFungibleToken.INFT.

@rahul-kothari
Copy link
Author

rahul-kothari commented Mar 9, 2021 via email

@oliviermilla
Copy link

sorry my bad, wrong repo :) the "n" is indeed not there ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback P-Low question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants