Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put assertions and post-conditions in the generic transactions #222

Closed
joshuahannan opened this issue May 20, 2024 · 0 comments · Fixed by #226
Closed

Put assertions and post-conditions in the generic transactions #222

joshuahannan opened this issue May 20, 2024 · 0 comments · Fixed by #226
Assignees
@joshuahannan
Labels
enhancement New feature or request Feedback SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board Technical Debt

Comments

@joshuahannan
Copy link
Member

joshuahannan commented May 20, 2024 •
edited
Loading

Issue To Be Solved

If we are going to encourage projects to use the generic token transactions, we should add assertions and/or post-conditions to them to make sure that they are behaving properly.

Transactions in Question

Suggest A Solution

Add these conditions:

  • Make sure the withdrawn NFT is the same type that is defined by the specified contract
  • Make sure it has the correct ID
  • Think of others
@joshuahannan joshuahannan added enhancement New feature or request Feedback Technical Debt SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board labels May 20, 2024
@joshuahannan joshuahannan self-assigned this May 20, 2024
@joshuahannan joshuahannan moved this to 🔖 Ready for Pickup in 🌊 Flow 4D May 20, 2024
@joshuahannan joshuahannan moved this from 🔖 Ready for Pickup to 🏗 In Progress in 🌊 Flow 4D Jul 9, 2024
@sisyphusSmiling sisyphusSmiling mentioned this issue Jul 9, 2024
Merged
6 tasks
@joshuahannan joshuahannan mentioned this issue Jul 9, 2024
Merged
6 tasks
@joshuahannan joshuahannan moved this from 🏗 In Progress to 👀 In Review in 🌊 Flow 4D Jul 9, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in 🌊 Flow 4D Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuahannan joshuahannan

Labels
enhancement New feature or request Feedback SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board Technical Debt
Projects
🌊 Flow 4D
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add flix and test generic transactions onflow/flow-nft
1 participant
@joshuahannan