Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds generic burn transaction #238

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Adds generic burn transaction #238

merged 5 commits into from
Jan 21, 2025

Conversation

joshuahannan
Copy link
Member

@joshuahannan joshuahannan commented Jan 7, 2025 •
edited
Loading

Closes: #236

Description

Adds a transaction that withdraws specified NFTs of the same type from its standard path and sends it to Burner, destroying it.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Re-reviewed Files changed in the Github PR explorer

@joshuahannan joshuahannan mentioned this pull request Jan 7, 2025
Closed
sisyphusSmiling
sisyphusSmiling approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@sisyphusSmiling sisyphusSmiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would just recommend including the suggested change for the sake of transaction efficiency, though relatively minor.

transactions/generic_destroy_nft.cdc Outdated Show resolved Hide resolved
@joshuahannan joshuahannan merged commit 5953dd7 into master Jan 21, 2025
2 checks passed
@joshuahannan joshuahannan deleted the update-deps branch January 21, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluesign bluesign bluesign left review comments

@sisyphusSmiling sisyphusSmiling sisyphusSmiling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a generic transaction to burn NFTs
3 participants
@joshuahannan @bluesign @sisyphusSmiling