Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser.services property incorrect type #54

Open
Julusian opened this issue Jul 18, 2024 · 0 comments
Open

Browser.services property incorrect type #54

Julusian opened this issue Jul 18, 2024 · 0 comments

Comments

@Julusian
Copy link

The services getter on the Browser class claims to return the class Service, when it actually returns plain objects which mostly happens to line up with that class.

Looking into the code, this issue runs deeper the return value of buildServicesFor inside the Browser class is returning KeyValue objects, which is then cast to Service, with the remaining logic assuming it is of type Service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant