Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equal 11 problem with input type of string #2148

Closed
mikeessen opened this issue Mar 28, 2023 · 0 comments
Closed

Equal 11 problem with input type of string #2148

mikeessen opened this issue Mar 28, 2023 · 0 comments
Labels
bug An unexpected problem or unintended behavior

Comments

@mikeessen
Copy link
Contributor

mikeessen commented Mar 28, 2023

Describe the bug

ONNX Equal 11 does not support a type of string, but Equal version 11 in tf2onnx/onnx_opset/logical.py is implemented to support all types including string.

See https://github.com/onnx/onnx/blob/main/docs/Changelog.md#Equal-11 for supported types.

Note that the ONNX documentations shows that Equal-19 will support string. But, Equal version 11 in tf2onnx should still work with ONNX Equal 11.

Urgency

An update to tf2onnx/onnx_opset/logical.py is created to work around and a PR with the update will be submitted.

System information

  • OS Platform and Distribution: macOS 13.2.1
  • TensorFlow Version: 2.10.0
  • Python version: 3.10.9
  • ONNX version : 1.13.1
  • ONNXRuntime: 1.13.1
@mikeessen mikeessen added the bug An unexpected problem or unintended behavior label Mar 28, 2023
@mikeessen mikeessen changed the title Equal 11 porblem with input type of string Equal 11 problem with input type of string Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant