Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-select self by default on joining #73

Closed
vladfaust opened this issue Mar 2, 2019 · 0 comments
Closed

Auto-select self by default on joining #73

vladfaust opened this issue Mar 2, 2019 · 0 comments
Assignees
Labels
breaking Breaking change enhancement New feature or request
Milestone

Comments

@vladfaust
Copy link
Member

Post.first.select(Post).join(author: true) { |x| x.select(:name) }

Currently the developer has to explicitly add .select(Post), otherwise the post isn't loaded. By it should be loaded by default unless explicitly called .select. However, .join can be called at any time, even before parent query .select, therefore some kind of @select_self : Bool = true variable should be introduced in the Query.

@vladfaust vladfaust added enhancement New feature or request breaking Breaking change labels Mar 2, 2019
@vladfaust vladfaust added this to the next minor milestone Mar 2, 2019
@vladfaust vladfaust self-assigned this Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant