EJSON.clone() broken for objects with a numeric "length" attribute

[vsivsi]

This issue occurs because EJSON.clone() uses the underscore.js _.each() method to traverse objects

This is notoriously broken in underscore (see e.g. jashkenas/underscore#1590) for objects with a numeric length attribute, such as MongoDB GridFS file documents.

Meteor.js has patched its private copy of underscore to solve this issue (and likely others).

All Oortcloud projects which have adopted Meteor.js code that depends on underscore.js probably should switch to Meteor's version.

[emgee3]

So I agree that we should use the same version that Meteor does, using a fork of an outdated version of _ makes me sad.

[emgee3]

I've published updated versions of ddp-ejson, ddp-srp and node-ddp-client.

[vsivsi]

Thanks for doing this! It makes me sad too, but we would gain nothing by trying to get out in front of Meteor on this. Have a good weekend.