Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPDS 2 : currentPage should have a min value #74

Open
llemeurfr opened this issue Jan 18, 2024 · 3 comments
Open

OPDS 2 : currentPage should have a min value #74

llemeurfr opened this issue Jan 18, 2024 · 3 comments

Comments

@llemeurfr
Copy link

currentPage of a feed is defined as "Indicates the current page number." and is an Integer.

Some developers start with 0, others with 1. It would be good to normalize the min value, my preference being 1.

@HadrienGardeur
Copy link
Member

This could also be enforced in the JSON schema.

@HadrienGardeur
Copy link
Member

I've just reviewed our JSON Schema and it uses an exclusive minimum of 0: https://github.com/opds-community/drafts/blob/master/schema/feed-metadata.schema.json#L42

This means that the minimum allowed value is actually 1. We could switch to minimum: 1 if it makes things clearer, is there any other change or addition that you would make @llemeurfr ?

@llemeurfr
Copy link
Author

A clarification in the JSON schema is not sufficient. A mention in the specification is required to avoid mistakes.

Other properties may require the same level of precision in the specification, I didn't check the general case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants