Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace occurrences of old names of products, when deploying to new server #35

Closed
jpmckinney opened this issue Oct 2, 2019 · 9 comments
Labels
S: kingfisher-collect Relating to the Kingfisher Collect service

Comments

@jpmckinney
Copy link
Member

'ocdskit-web' will become confusing over time, as we (and new users) will forget that it was the old name for Toucan.

@ghost
Copy link

ghost commented Oct 7, 2019

Is that https://github.com/open-contracting/deploy/blob/master/salt-config/roster#L13 ?

In fairness we could probably rename most of those machine names :-) They are only used internally by salt. Need to be careful tho, to make sure right variables are still applied.

@jpmckinney
Copy link
Member Author

jpmckinney commented Oct 7, 2019

'ocdskit-web' also occurs in filenames and in other files. It'll be less confusing in future if we use Toucan consistently across all repos, documentation, etc.

The other machine names at least roughly correspond to FQDNs, so they are not going to be confusing (in the same way).

@ghost
Copy link

ghost commented Oct 7, 2019

Fair point. When doing this we'll have to be a bit careful; if you just change the salt rule to install a Apache config called "toucan" instead of "webkit", say, it won't automatically remove the old one - so you'll end up with 2 Apache configs, and so on. Might be a bit of downtime, just 5 mins or so. All doable tho; prioritise away.

@ghost
Copy link

ghost commented Oct 7, 2019

@jpmckinney
Copy link
Member Author

jpmckinney commented Oct 22, 2019

As part of this we can start documenting what types of Salt configuration changes require removing earlier configurations (e.g. renaming configuration files).

Update: See https://ocdsdeploy.readthedocs.io/en/latest/how-to/update.html#remove-content

@jpmckinney
Copy link
Member Author

jpmckinney commented Nov 6, 2019

There are now only 3 occurrences in toucan_pillar.sls and toucan.sls. Changing those are low priority. We can replace them if/when we need to rebuild the server.

@jpmckinney jpmckinney removed their assignment Apr 16, 2020
@jpmckinney
Copy link
Member Author

Similarly, there are a few occurrences of scrape instead of collect viz. Kingfisher Collect.

@jpmckinney jpmckinney changed the title Toucan: Rename some ocdskit-web occurrences Toucan: Rename some ocdskit-web and scrape occurrences Jul 21, 2020
@jpmckinney jpmckinney removed the toucan label Nov 20, 2020
@jpmckinney jpmckinney changed the title Toucan: Rename some ocdskit-web and scrape occurrences Replace occurrences of old names of products, when deploying to new server Nov 20, 2020
@jpmckinney jpmckinney added S: kingfisher-collect Relating to the Kingfisher Collect service toucan labels Dec 25, 2020
@jpmckinney jpmckinney removed the toucan label May 5, 2021
@jpmckinney
Copy link
Member Author

jpmckinney commented May 5, 2021

Toucan will be decommissioned, so that is no longer an issue. As shared on Slack:

Once the new flattening tool is deployed, Toucan will just be a web interface to OCDS Kit. However, web analytics show very low usage (low tens of users per month, mostly from Paraguay, the UK and Canada, which is where our teams work). To free up time and resources for more impactful work, Toucan will therefore be decommissioned. People who can’t install OCDS Kit locally will be referred to the OCDS Kit tutorial notebook, and Flatten Tool users will be directed to the new flattening tool.

@jpmckinney
Copy link
Member Author

Similarly, there are a few occurrences of scrape instead of collect viz. Kingfisher Collect.

The helpdesk deployment of Collect is expected to last a while (at least until we upgrade the OS), and it's not worth the effort to get everyone to change their log-in info, so I'll close this issue. We'll likely/hopefully notice the possible renaming when re-deploying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: kingfisher-collect Relating to the Kingfisher Collect service
Projects
None yet
Development

No branches or pull requests

1 participant