diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1131dd015..4662645f0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,6 +22,7 @@ jobs: java-version: '8' distribution: 'temurin' cache: maven + cache-dependency-path: './pom.xml' - name: Cache local Maven repository uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4 diff --git a/hooks/open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/MetricsHook.java b/hooks/open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/MetricsHook.java index 10b1bf288..9f798e3f5 100644 --- a/hooks/open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/MetricsHook.java +++ b/hooks/open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/MetricsHook.java @@ -134,7 +134,7 @@ public void error(HookContext ctx, Exception error, Map hints) { } @Override - public void finallyAfter(HookContext ctx, Map hints) { + public void finallyAfter(HookContext ctx, FlagEvaluationDetails details, Map hints) { activeFlagEvaluationsCounter.add(-1, Attributes.of(flagKeyAttributeKey, ctx.getFlagKey())); } diff --git a/hooks/open-telemetry/src/test/java/dev/openfeature/contrib/hooks/otel/MetricsHookTest.java b/hooks/open-telemetry/src/test/java/dev/openfeature/contrib/hooks/otel/MetricsHookTest.java index 942f82c01..1d521e0ce 100644 --- a/hooks/open-telemetry/src/test/java/dev/openfeature/contrib/hooks/otel/MetricsHookTest.java +++ b/hooks/open-telemetry/src/test/java/dev/openfeature/contrib/hooks/otel/MetricsHookTest.java @@ -188,7 +188,7 @@ public void finally_stage_validation() { final MetricsHook metricHook = new MetricsHook(telemetryExtension.getOpenTelemetry()); // when - metricHook.finallyAfter(commonHookContext, null); + metricHook.finallyAfter(commonHookContext, null, null); List metrics = telemetryExtension.getMetrics(); // then diff --git a/pom.xml b/pom.xml index 29e949122..cafc1767c 100644 --- a/pom.xml +++ b/pom.xml @@ -67,8 +67,8 @@ dev.openfeature sdk - - [1.12,2.0) + + [1.14,1.99999) provided diff --git a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java index fd617af1f..192c92e68 100644 --- a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java +++ b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java @@ -24,6 +24,7 @@ import dev.openfeature.sdk.Value; import dev.openfeature.sdk.exceptions.ParseError; import dev.openfeature.sdk.exceptions.TypeMismatchError; +import java.util.Map; import java.util.function.Consumer; import java.util.function.Supplier; import lombok.extern.slf4j.Slf4j;