Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow global otel configuration extraction #505

Merged
merged 4 commits into from
Oct 26, 2023
Merged

feat: Allow global otel configuration extraction #505

merged 4 commits into from
Oct 26, 2023

Conversation

Kavindu-Dodan
Copy link
Collaborator

This PR

Fixes #390 by completing the missing task - Use always OTel interceptor

Flagd java provider now allows extracting tracer from GlobalTelemetry

FlagdOptions options =
        FlagdOptions.builder()
            .withGlobalTelemetry(true)
            .build();

FlagdProvider flagdProvider = new FlagdProvider(options);

@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner October 17, 2023 21:52
@Kavindu-Dodan Kavindu-Dodan mentioned this pull request Oct 17, 2023
Closed
@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/flagd-global-otel-option branch from 09fce27 to 3e0dba9 Compare October 17, 2023 22:20
thisthat
thisthat reviewed Oct 18, 2023
View reviewed changes
providers/flagd/README.md Outdated Show resolved Hide resolved
thisthat
thisthat reviewed Oct 18, 2023
View reviewed changes
providers/flagd/README.md Outdated Show resolved Hide resolved
Kavindu-Dodan and others added 2 commits October 25, 2023 09:48
@Kavindu-Dodan
allow global telemetry option
c06b40e 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan @thisthat
Update providers/flagd/README.md
608f100 
Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/flagd-global-otel-option branch from 795de52 to 608f100 Compare October 25, 2023 16:48
toddbaert
toddbaert approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, since this all makes sense to me. I am, however, very confused by this thread, so I'd like to hear back from @thisthat at some point.

@Kavindu-Dodan
improve doc
b0d3bb0 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@toddbaert toddbaert merged commit addbc31 into open-feature:main Oct 26, 2023
@github-actions github-actions bot mentioned this pull request Oct 26, 2023
Merged
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
@renovate
chore(deps): update github/codeql-action digest to 12aa0a6 (open-feat…
893d0da 
…ure#505)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisthat thisthat thisthat approved these changes

@toddbaert toddbaert toddbaert approved these changes

@beeme1mr beeme1mr Awaiting requested review from beeme1mr

Assignees

@beeme1mr beeme1mr

@Kavindu-Dodan Kavindu-Dodan

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flagd] follow-up refactoring
4 participants
@Kavindu-Dodan @thisthat @toddbaert @beeme1mr