Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get float value? #32

Closed
toddbaert opened this issue Jul 5, 2022 · 3 comments · Fixed by #34
Closed

Get float value? #32

toddbaert opened this issue Jul 5, 2022 · 3 comments · Fixed by #34

Comments

@toddbaert
Copy link
Member

toddbaert commented Jul 5, 2022

It seems like the Java SDK doesn't support floats. Is that something that should be supported? I suppose this can be worked around with strings, but I wonder if decimal values are important enough to be supported, especially fractional values like .5 could be practical.

Relevant part of the spec: https://github.com/open-feature/spec/blob/main/specification/types.md#number

@justinabrahms
Copy link
Member

I'm not clear on how to handle this one. I wonder if we could just deal with Numbers and defer it to the caller? https://docs.oracle.com/javase/8/docs/api/java/lang/Number.html

@toddbaert
Copy link
Member Author

I'm not clear on how to handle this one. I wonder if we could just deal with Numbers and defer it to the caller? https://docs.oracle.com/javase/8/docs/api/java/lang/Number.html

I think that's a fine solution, personally.

Paging @agentgonzo, interested in your take on this one.

@thomaspoignant
Copy link
Member

I have open #34 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants