Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag evaluation metadata to evaluation details #111

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

nicklasl
Copy link
Member

@nicklasl nicklasl commented Nov 17, 2024

This PR

  • adds flag metadata to flag evaluation according to spec.

Related Issues

Fixes #63

Notes

I also sneaked in the removal of BaseEvaluation in this PR. This interface was not really used.

Copy link
Member

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, I just have a question about the getAny() and why do we need it?

@nicklasl nicklasl changed the title feat: Flag metadata feat: add flag evaluation metadata to evaluation details Nov 18, 2024
Copy link
Member

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@nicklasl nicklasl merged commit 6e9aa29 into open-feature:main Nov 18, 2024
6 checks passed
@nicklasl nicklasl deleted the flag-metadata branch November 18, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag metadata implementation
4 participants