Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: kube-flagd-proxy deployment #412

Merged
merged 39 commits into from
Mar 31, 2023
Merged

feat: kube-flagd-proxy deployment #412

merged 39 commits into from
Mar 31, 2023

Conversation

james-milligan
Copy link
Contributor

This PR

  • adds new provider type kube-proxy
  sources:
  - source: default/example
    provider: kube-proxy

Use the kube-proxy provider + create a deployment with the normal deployment path, the operator will deploy Kubernetes proxy, denying pod deployment until it is ready to receive requests

Related Issues

Fixes #1234523

Notes

Follow-up Tasks

How to test

@james-milligan
kube-proxy deployment
1121d00 
Signed-off-by: James Milligan <[email protected]>
@james-milligan james-milligan changed the title POC: flagd-kube-proxy deployment feat: POC flagd-kube-proxy deployment Mar 22, 2023
@Kavindu-Dodan
Copy link
Contributor

Cool work. I like the approach you took with provider: kube-proxy option.

Look forward to the refined PR

@james-milligan
remove comment
c9d5bb0 
Signed-off-by: James Milligan <[email protected]>
@codecov
Copy link

codecov bot commented Mar 24, 2023 •
edited
Loading

Codecov Report

Merging #412 (eb7b15c) into main (5ba5bc9) will decrease coverage by 6.50%.
The diff coverage is 51.76%.

@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   84.26%   77.76%   -6.50%     
==========================================
  Files          19       21       +2     
  Lines        1061     1300     +239     
==========================================
+ Hits          894     1011     +117     
- Misses        138      248     +110     
- Partials       29       41      +12
Impacted Files Coverage Δ
...pis/core/v1alpha1/flagsourceconfiguration_types.go 98.76% <0.00%> (-1.24%) ⬇️
pkg/utils/utils.go 38.09% <0.00%> (-61.91%) ⬇️
webhooks/pod_webhook.go 78.23% <5.26%> (-11.00%) ⬇️
...rollers/core/flagsourceconfiguration/controller.go 46.37% <57.14%> (+1.21%) ⬆️
webhooks/error_types.go 57.14% <57.14%> (ø)
...s/core/flagsourceconfiguration/kube-flagd-proxy.go 77.41% <77.41%> (ø)
webhooks/pod_webhook_deprecated.go 47.61% <100.00%> (ø)
Flag Coverage Δ
component-tests 75.83% <12.30%> (-9.04%) ⬇️
unit-tests 61.69% <48.62%> (-2.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@james-milligan
proxy deployment timeout error
2013ea6 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
basic unit tests
3aa96ff 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
merge conflicts
b4dc16c 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
test refactor
bada658 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
docs
179b0be 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
import fix
a790efd 
Signed-off-by: James Milligan <[email protected]>
@james-milligan james-milligan changed the title feat: POC flagd-kube-proxy deployment feat: flagd-kube-proxy deployment Mar 28, 2023
@james-milligan james-milligan marked this pull request as ready for review March 28, 2023 12:03
@james-milligan james-milligan requested a review from a team as a code owner March 28, 2023 12:03
@james-milligan
linting fixes
38b9d4d 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
Merge http://github.com/open-feature/open-feature-operator into kube-…
61fd4d1 
…proxy-deployment
@james-milligan
renovate config
026d04b 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
renovate marker
877e790 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
chart readme
fe3c4bf 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
cleanup
45bbaa8 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
table format
9704c52 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
docs
648ada3 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
file name fix
c73cca6 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
file name fix
bc98c50 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
SA fix
db9b326 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
docs
29f9906 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
tightened permissions
678d98e 
Signed-off-by: James Milligan <[email protected]>
@james-milligan james-milligan changed the title feat: flagd-kube-proxy deployment feat: kube-flagd-proxy deployment Mar 29, 2023
@james-milligan
isolate kube proxy handler
e658051 
Signed-off-by: James Milligan <[email protected]>
@james-milligan james-milligan mentioned this pull request Mar 30, 2023
Merged
thisthat
thisthat approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

toddbaert pushed a commit to open-feature/flagd that referenced this pull request Mar 30, 2023
@james-milligan
feat!: proposal - rename kube-flagd-proxy to flagd-proxy (#576)
223de99 
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

- renames package `kube-flagd-proxy` to `flagd-proxy`
- updates all references of `kube-flagd-proxy` to `flagd-proxy`

### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->


open-feature/open-feature-operator#412 (comment)

### Notes
<!-- any additional notes for this PR -->

### Follow-up Tasks
<!-- anything that is related to this PR but not done here should be
noted under this section -->
<!-- if there is a need for a new issue, please link it here -->

### How to test
<!-- if applicable, add testing instructions under this section -->

---------

Signed-off-by: James Milligan <[email protected]>
@james-milligan
refactor
b9928a9 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
bug fix + refactor
22a64e0 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
merge
ed2f128 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
tag fix
ed929f7 
Signed-off-by: James Milligan <[email protected]>
@james-milligan
version fix
eb7b15c 
Signed-off-by: James Milligan <[email protected]>
@toddbaert toddbaert self-requested a review March 31, 2023 16:12
@james-milligan james-milligan merged commit 651c63c into open-feature:main Mar 31, 2023
@github-actions github-actions bot mentioned this pull request Mar 31, 2023
Merged
@toddbaert toddbaert mentioned this pull request Apr 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr left review comments

@AlexsJones AlexsJones AlexsJones left review comments

@thisthat thisthat thisthat approved these changes

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@toddbaert toddbaert toddbaert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@james-milligan @Kavindu-Dodan @toddbaert @beeme1mr @thisthat @AlexsJones