fix: restrict permissions to only access specific CRB #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacherfl
force-pushed
the
fix/reduce-permissions
branch
from
e1b9184 to
7fa9471
Compare
Codecov Report
@@ Coverage Diff @@
## main #436 +/- ##
=======================================
Coverage 78.00% 78.00%
=======================================
Files 21 21
Lines 1323 1323
=======================================
Hits 1032 1032
Misses 251 251
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
bacherfl
force-pushed
the
fix/reduce-permissions
branch
from
33c8260 to
203f638
Compare
Signed-off-by: Florian Bacher <[email protected]>
thisthat
approved these changes
Apr 3, 2023
james-milligan
approved these changes
Apr 3, 2023
toddbaert
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Reviewing the BackfillPermissions method, this looks right to me. I dont think we need anything else.
Once #377 has been implemented, this permission can likely be dropped completely
@bacherfl I think the above issue is basically done by @james-milligan with #412, but I think the plan was not to get rid of the direct k8s sync at least for now. So I think we will need to keep this until we decide to move away from that (if we do at all).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the required permissions for the OFO to only be able to modify the
open-feature-operator-flagd-kubernetes-syncClusterRoleBinding.Once #377 has been implemented, this permission can likely be dropped completely