Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement API-level hooks #72

Closed
2 tasks
tcarrio opened this issue Jan 4, 2023 · 2 comments · Fixed by #139
Closed
2 tasks

Implement API-level hooks #72

tcarrio opened this issue Jan 4, 2023 · 2 comments · Fixed by #139
Labels
1.0-release Required for a 1.0 release

Comments

@tcarrio
Copy link
Member

tcarrio commented Jan 4, 2023 •
edited by toddbaert
Loading

There are no global hooks nor way to add hooks to the global API client.

This is required as per the spec.

Definition of done:

  • hooks can be added to the global API, and are run with flag evaluation
  • associated tests
@agardnerIT agardnerIT mentioned this issue Mar 29, 2023
Closed
@toddbaert toddbaert mentioned this issue Apr 18, 2023
Open
14 tasks
@toddbaert toddbaert added the 1.0-release Required for a 1.0 release label Apr 18, 2023
@jamescarr
Copy link
Contributor

Looks like Hook support were implemented in #6?

@tcarrio
Copy link
Member Author

tcarrio commented Jun 30, 2023

Hooks as a general feature are available at the client level, but the singleton API should also be able to define hooks essentially globally.

This is referenced in the docs here and spec here

@federicobond federicobond mentioned this issue Jul 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0-release Required for a 1.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement api-level hooks federicobond/python-sdk
3 participants
@jamescarr @tcarrio @toddbaert