Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook context merging w/ api ctx #124

Closed
justinabrahms opened this issue Aug 7, 2022 · 3 comments · Fixed by #125
Closed

Hook context merging w/ api ctx #124

justinabrahms opened this issue Aug 7, 2022 · 3 comments · Fixed by #125

Comments

@justinabrahms
Copy link
Member

Requirement 4.3.4 says:

When before hooks have finished executing, any resulting evaluation context MUST be merged with the invocation evaluation context with the invocation evaluation context taking precedence in the case of any conflicts.

How does provider and client context fix here?

I think the order that makes sense is (top-most wins):

  1. invocation
  2. before hook
  3. client
  4. api

That sound right?

@justinabrahms
Copy link
Member Author

The above is what I've implemented at open-feature/java-sdk@df1a083#diff-e68548048652a4655f9bdf043de6c238360b9f05b9d61267a12423617e377303L51

We should either fix that commit or update 4.3.4 to have the complete correct merge order.

@toddbaert
Copy link
Member

This sounds right. We also have 3.2.2. I feel like there's some redundancy here, and I'm not 100% sure how to rectify it.

@toddbaert
Copy link
Member

@beeme1mr had a question that gave me pause: #125 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants