Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: Clicking a component in panels moves interactive map to center on its icon #503

Closed
2 of 3 tasks
aaronchongth opened this issue Sep 13, 2021 · 12 comments · Fixed by #530
Closed
2 of 3 tasks
Assignees
Labels
blocked Progress is blocked by another issue enhancement New feature or request

Comments

@aaronchongth
Copy link
Member

aaronchongth commented Sep 13, 2021

Feature request

Status

Per VC, this is blocked by the implementation of different Tabs,

but can be started on independently when each tab is completed.

Description

It is sometimes difficult for users to find the object of interest (robot, door, lift, etc) on the interactive map if the scale of the map is large. Consider centering the interactive map onto the object's icon when the object is clicked on the other panels, in the tabs that the interactive map exists.

Implementation considerations

  • There might be users who do not want this feature, as they have zoomed out to make the whole map visible, this might make them need to zoom out every time they click on an object to check its state. Consider adding a toggle in the settings if this feature should be enabled.
@aaronchongth aaronchongth added the enhancement New feature or request label Sep 13, 2021
@aaronchongth aaronchongth changed the title Clicking a component in panels moves dynamic map to center on its icon Clicking a component in panels moves interactive map to center on its icon Sep 15, 2021
@aaronchongth aaronchongth changed the title Clicking a component in panels moves interactive map to center on its icon dashboard: Clicking a component in panels moves interactive map to center on its icon Sep 15, 2021
@koonpeng
Copy link
Collaborator

We should start with a figma prototype first.

@vallq
Copy link
Contributor

vallq commented Sep 20, 2021

I think @ChawinTan has built this centering feature in one of the branches previously? Correct me if I am wrong!

But also there would be the design issue of one-click performing 2 different interactions, similar to what we discussed previously for the task panel right, @koonpeng? if clicking on a component shows information on a side panel and performs the centering on the map.

image
I foresee it would look something like this? the space below the map is empty for now, perhaps the toggle mentioned could be here, or it can be in the settings drawer

@aaronchongth
Copy link
Member Author

We should start with a figma prototype first.

Agreed! @koonpeng, I just added this line in the self-check, let me know what you think, #513

I think @ChawinTan has built this centering feature in one of the branches previously? Correct me if I am wrong!

Yup! It is in one of the branches and it was previously blocked by the removal of the omni-panel. I think the individual tabs should be a priority, before the feature for centering of icons on itneractive maps can be added in.

@koonpeng koonpeng added the blocked Progress is blocked by another issue label Sep 27, 2021
@aaronchongth
Copy link
Member Author

Per VC, this is blocked by the implementation of different Tabs,

but can be started on independently when each tab is completed.

@vallq
Copy link
Contributor

vallq commented Oct 6, 2021

figma-centering-of-icon

@ChawinTan
Copy link

ChawinTan commented Oct 21, 2021

@Val and @aaronchongth Will the object be centered when it is clicked on the map itself or when the cell associated with it in the panel is clicked on?

The animation suggest the former but my understanding of this feature is the latter. If the map is really big, the user will have problems finding the item on the map to click on.

@aaronchongth
Copy link
Member Author

Oh good catch! I think we would like the latter as mentioned by @ChawinTan. The implementation would hopefully be just a migration from our other feature branches. @vallq could you help update the prototype when you have some free cycles?

@vallq
Copy link
Contributor

vallq commented Oct 21, 2021

Oh okay I always thought it was the former with the clicking of icons, got it!

@aaronchongth aaronchongth linked a pull request Oct 25, 2021 that will close this issue
5 tasks
@ChawinTan
Copy link

One last question ... I assume that the toggle will be in the settings Tab that is currently not up yet? I'm going ahead to add one more task on the checklist above

@vallq
Copy link
Contributor

vallq commented Oct 27, 2021

I think the settings drawer is just hidden for now, as for whether we want it to be a separate tab, I think this can be discussed? I have no qualms of leaving it as the drawer unless we have a lot of things for the user to change at their discretion

@ChawinTan
Copy link

ChawinTan commented Oct 28, 2021

I think the settings drawer is just hidden for now, as for whether we want it to be a separate tab, I think this can be discussed? I have no qualms of leaving it as the drawer unless we have a lot of things for the user to change at their discretion

Thanks for the reply! I was following the figma mock up and it has a separate settings tab. I will leave it hidden for now until needed.

ignore the above, I was looking at the old mock up

@ChawinTan
Copy link

The zooming logic is implemented in both panels, now pending both to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Progress is blocked by another issue enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants