-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboard: Clicking a component in panels moves interactive map to center on its icon #503
Comments
We should start with a figma prototype first. |
I think @ChawinTan has built this centering feature in one of the branches previously? Correct me if I am wrong! But also there would be the design issue of one-click performing 2 different interactions, similar to what we discussed previously for the task panel right, @koonpeng? if clicking on a component shows information on a side panel and performs the centering on the map.
|
Agreed! @koonpeng, I just added this line in the self-check, let me know what you think, #513
Yup! It is in one of the branches and it was previously blocked by the removal of the omni-panel. I think the individual tabs should be a priority, before the feature for centering of icons on itneractive maps can be added in. |
Per VC, this is blocked by the implementation of different Tabs, but can be started on independently when each tab is completed. |
@Val and @aaronchongth Will the object be centered when it is clicked on the map itself or when the cell associated with it in the panel is clicked on? The animation suggest the former but my understanding of this feature is the latter. If the map is really big, the user will have problems finding the item on the map to click on. |
Oh good catch! I think we would like the latter as mentioned by @ChawinTan. The implementation would hopefully be just a migration from our other feature branches. @vallq could you help update the prototype when you have some free cycles? |
Oh okay I always thought it was the former with the clicking of icons, got it! |
One last question ... I assume that the toggle will be in the settings Tab that is currently not up yet? I'm going ahead to add one more task on the checklist above |
I think the settings drawer is just hidden for now, as for whether we want it to be a separate tab, I think this can be discussed? I have no qualms of leaving it as the drawer unless we have a lot of things for the user to change at their discretion |
ignore the above, I was looking at the old mock up |
The zooming logic is implemented in both panels, now pending both to be merged |
Feature request
Status
Per VC, this is blocked by the implementation of different Tabs,
but can be started on independently when each tab is completed.
Description
It is sometimes difficult for users to find the object of interest (robot, door, lift, etc) on the interactive map if the scale of the map is large. Consider centering the interactive map onto the object's icon when the object is clicked on the other panels, in the tabs that the interactive map exists.
Implementation considerations
The text was updated successfully, but these errors were encountered: