Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Flag to consume yaml file at path to prevent eviction from cache of configured repos #26

Closed
2 tasks done
jpmcb opened this issue Jul 20, 2023 · 0 comments · Fixed by #28
Closed
2 tasks done

Comments

@jpmcb
Copy link
Member

jpmcb commented Jul 20, 2023

Type of feature

🍕 Feature

Current behavior

Currently, besides consistently sending requests, there's no way to prevent a repo from being evicted from the disk cache. But even then, a very hot cache could evict a repo from the disk even if it's being queried frequently.

There are a subset of repos (like kubernetes/kubernets, the open-sauced repos, etc.) that we probably don't want to evict from the cache regardless of its position.

Suggested solution

During server startup, there should be an optional flag that sets a path to a yaml file with a list of repos that should never be evicted from the cache, regardless of their position.

$ ./pizza-oven --config /var/config/pizza-oven-config.yaml
never-evict-repos:
- https://github.com/kubernetes/kubernetes
- https://github.com/open-sauced/pizza
- https://github.com/open-sauced/pizza-cli
- ...

In the future, this yamlfile could become a more general configuration file that users utilize over environment variables, but for now, this setup is fine.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant