-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] new card limit in optimizer.find_optimal_retention #600
[Feature Request] new card limit in optimizer.find_optimal_retention #600
Comments
Because we should compare the final amount of memorization in the same total cost. |
The workload graph is based on "minutes of study per day", so it fails to achieve a certain goal if you spend less time per day, but more time per card and learn much less. |
Is the above about Optimizer and too different from Simulator? This comment below is about Simulator. Do you mean Simulator always introduces that 1 card in my deck even if the daily limits have been reached? But there are both repetitions and time limits: new_cards_limits = 20
review_limits = 400
max_time_limts = 10000 for idx in need_learn.index:
if (
learned >= new_cards_limits
or review_time_today + learn_time_today >= max_time_limts
):
break I incorrectly assumed that they applied to the same thing, but apparently new cards are limited only by the day's time, not reps. |
I guess we are talking two different problems. My focus is the new card limit will mess up the function of finding the optimal retention. If we set new card limit, the real time cost per day will be inconsistent. Your focus is Anki and the simulator has new card limit, so the optimizer should also have new card limit. But I don't want to introduce the new card limit for the above reason. |
My focus is Anki, because that's where I can use the optimal retention I am trying to find. Apparently the function Optimizer uses is simulate() in fsrs-optimizer/src/fsrs_optimizer/fsrs_simulator.py |
But I think it doesn't matter because the key of finding optimal retention is to maximize the memorization with fixed time cost. New card limit will break the time cost consistency. |
Okay, I want to memorize everything by studying 1 minute a day for a week. Not because I don't have the necessary 2 minutes a day, but because I want to save time. Optimizer determines that it won't work, and shows that on the Cumulative Learn Count graph, which does not say the exact number. To find out what will work, I guess I should use the separate Simulator, and try different parameters to determine both the time cost and the number of study days. I will waste a lot of time generating the table manually (maybe with a couple regexp to reformat the output into a table), so maybe I should edit the simulator to generate it automatically if I can. Because I won't just guess the exact optimal retention by trying to save time and learn more… And then Optimizer's output will still depend on the input. Maybe it's the separate Simulator that should be improved and possibly generate another graph. What it currently shows:
A graph shows "time in minutes per day (14 days average)". It is hard to determine the number of seconds to specify in Optimizer from the graph. Give it too much, and it will use more time where it could use less at little cost. Simulator allows for spikes thanks to the limit, but Optimizer would use their cost for all days? Or does Simulator allow for spikes over the limit?
And after all, I will need to know how many new cards to introduce every day, because I am not going to look at whether I spent the target time cost for each deck that day (I guess the latter would require some really strict time management). So to take advantage of those programs that have time cost as input, Anki also needs to be improved by adding features that had been done in add-ons before. |
But the
They both are now allow to exceed the limit. And they don't run out of cost when all news cards have been learned. |
Which module is related to your feature request?
Optimizer
Is your feature request related to a problem? Please describe.
That makes it difficult to compare the output.
Describe the solution you'd like
Optimizer should obey a new card limit like Simulator.
Describe alternatives you've considered
The text was updated successfully, but these errors were encountered: