Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File storage extension - Optimize or replace bbolt database dependency #3150

Closed
djaglowski opened this issue Apr 16, 2021 · 1 comment
Closed

File storage extension - Optimize or replace bbolt database dependency #3150

djaglowski opened this issue Apr 16, 2021 · 1 comment
Assignees
@djaglowski
Milestone
Logs Support, Pha...

Comments

@djaglowski
Copy link
Member

djaglowski commented Apr 16, 2021 •
edited
Loading

I think it is OK to merge this PR and ignore the PR for now, but then immediately look for a better KV storage without spending time on adding a cache. I cannot imagine a KV storage being so slow (is it possible we do something wrong?). Surely something else should exist that has more reasonable performance.

Originally posted by @tigrannajaryan in #3087 (comment)
@djaglowski djaglowski self-assigned this Apr 16, 2021
@djaglowski djaglowski mentioned this issue Apr 16, 2021
Merged
@tigrannajaryan tigrannajaryan added this to the Logs Support, Phase 2 milestone Apr 16, 2021
@djaglowski
Copy link
Member Author

I believe this was resolved to a satisfactory degree in #3087, by disabling fsync for each write. If feedback warrants, we can revisit.

alexperez52 referenced this issue in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@bogdandrutu
Small nit fixes, remove unnecessary mock and overrides (#3150)
d1ee31e 
Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djaglowski djaglowski

Labels
None yet
Projects
None yet
Milestone
Logs Support, Phase 2
Development

No branches or pull requests
2 participants
@tigrannajaryan @djaglowski