Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Otlp Exporter : Add trace_state to Link #801

Closed
lalitb opened this issue May 26, 2021 · 2 comments
Closed

Otlp Exporter : Add trace_state to Link #801

lalitb opened this issue May 26, 2021 · 2 comments
Assignees
@lalitb
Labels
area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter bug Something isn't working release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs

Comments

@lalitb
Copy link
Member

lalitb commented May 26, 2021

trace_state is part of Link as per otlp protocol:
https://github.com/open-telemetry/opentelemetry-proto/blob/795cc815ce9bb438b46a4a7f6ecb465b52d50935/opentelemetry/proto/trace/v1/trace.proto#L214

This should be added in otel-cpp implementation:

opentelemetry-cpp/exporters/otlp/src/otlp_recordable.cc

Line 275 in 840701b

// TODO: Populate trace_state when it is supported by SpanContext

@lalitb lalitb added bug Something isn't working release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter labels May 26, 2021
@lalitb lalitb mentioned this issue May 26, 2021
Closed
10 tasks
@anshulkumar19
Copy link
Contributor

I can see that this issue is addressed in your PR #823, right?

@lalitb lalitb self-assigned this Jun 7, 2021
@lalitb
Copy link
Member Author

lalitb commented Jul 2, 2021

#823 resolves this

@lalitb lalitb closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lalitb lalitb

Labels
area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter bug Something isn't working release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lalitb @anshulkumar19