Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Otlp Exporter : Handle InstrumentationLibrary info ( name and version ) #802

Closed
lalitb opened this issue May 26, 2021 · 0 comments · Fixed by #823
Closed

Otlp Exporter : Handle InstrumentationLibrary info ( name and version ) #802

lalitb opened this issue May 26, 2021 · 0 comments · Fixed by #823
Assignees
@lalitb
Labels
area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter bug Something isn't working release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs
Milestone
1.0.0

Comments

@lalitb
Copy link
Member

lalitb commented May 26, 2021

InstrumentationLibrart version and name should be exported along with spans generated by that library:

https://github.com/open-telemetry/opentelemetry-proto/blob/795cc815ce9bb438b46a4a7f6ecb465b52d50935/opentelemetry/proto/trace/v1/trace.proto#L47

This is missing in otel-cpp implementation:

opentelemetry-cpp/exporters/otlp/src/otlp_recordable.cc

Line 346 in 840701b

// TODO: add instrumentation library to OTLP exporter.

@lalitb lalitb added bug Something isn't working area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs labels May 26, 2021
@lalitb lalitb mentioned this issue May 26, 2021
Closed
10 tasks
@lalitb lalitb mentioned this issue Jun 4, 2021
Merged
3 tasks
@lalitb lalitb self-assigned this Jun 7, 2021
@lalitb lalitb added this to the 1.0.0 GA milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lalitb lalitb

Labels
area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter bug Something isn't working release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Otlp Exporter : Handling InstrumentationLibrary, and Link's trace state lalitb/opentelemetry-cpp
1 participant
@lalitb