Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template semconv changes in otelhttp #5790

Closed
2 tasks
MrAlias opened this issue Jun 20, 2024 · 3 comments · Fixed by #6626
Closed
2 tasks

Template semconv changes in otelhttp #5790

MrAlias opened this issue Jun 20, 2024 · 3 comments · Fixed by #6626
Assignees
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jun 20, 2024

The semantic conventions migration strategy implemented for the otelhttp instrumentation needs to be applied to all other HTTP instrumentation. To do this, the internal/semconv package from needs to be templatized and added to the shared package so other HTTP instrumentation libraries can use it.

  • Server semconv template
  • Client semconv template

Blocked on otelhttp having a valid implementation:

@MrAlias MrAlias converted this from a draft issue Jun 20, 2024
@MrAlias MrAlias moved this from Blocked to Todo in Go: HTTP Semconv Migration Jun 20, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 20, 2024

Client semconv template work is still blocked: #5773

@dennisme
Copy link

#5773 is merged. Looks like this one is no longer blocked.

@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 18, 2024

We still need resolution for #6261 and #6262 to have a complete reference implementation to templatize.

@dmathieu dmathieu moved this from Blocked to Todo in Go: HTTP Semconv Migration Jan 16, 2025
@dmathieu dmathieu self-assigned this Jan 16, 2025
@MrAlias MrAlias moved this from Todo to In Progress in Go: HTTP Semconv Migration Jan 16, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: HTTP Semconv Migration Jan 17, 2025
@MrAlias MrAlias added this to the v1.34.0 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants