Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Target Allocator/Stateful Set Option #310

Closed
blakeromano opened this issue Aug 7, 2022 · 5 comments
Closed

Add Target Allocator/Stateful Set Option #310

blakeromano opened this issue Aug 7, 2022 · 5 comments
Labels
chart:operator Issue related to opentelemetry-operator helm chart Stale

Comments

@blakeromano
Copy link

The CRD for the collector allows for the creation of the target allocator for prometheus which uses some of the data from the config on the collector regarding prometheus. However the Helm Chart has not added that support as well. This should be done to add awareness and adoption of the Target Allocator especially since lots of work on the Prometheus/Opentelemetry work has been going on

@TylerHelmuth TylerHelmuth added the chart:operator Issue related to opentelemetry-operator helm chart label Aug 15, 2022
@TylerHelmuth
Copy link
Member

/cc @Allex1

@Allex1
Copy link
Contributor

Allex1 commented Aug 16, 2022

@blakeromano thanks for the heads up.
In the current operator chart we don't create/manage any custom resources (like the OpentelemetryCollector), we just provide some examples in the readme in order for the user to create and manage his own collector/s
Can you clarify what is the expectation regarding the targetAllocator resource?

@blakeromano
Copy link
Author

I am not suggesting that you have to use the CRD. The CRD happens to allow the option to start up a pod that uses the collector's prometheus configuration and spins up a pod to do that work. I'd like to see the Helm Chart also have that functionality. Maybe a new helm chart to combine to Collector and Operator into one helm chart?

@TylerHelmuth
Copy link
Member

@blakeromano is this issue related: #69

@blakeromano
Copy link
Author

Related yes. I think there is a benefit to having a helm chart that would do both the operator and collector without the usage of the CRD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:operator Issue related to opentelemetry-operator helm chart Stale
Projects
None yet
Development

No branches or pull requests

3 participants