Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-sdk] test-all-versions script is failing #2627

Closed
trivikr opened this issue Jan 7, 2025 · 2 comments · Fixed by #2628
Closed

[aws-sdk] test-all-versions script is failing #2627

trivikr opened this issue Jan 7, 2025 · 2 comments · Fixed by #2628
Labels
bug Something isn't working

Comments

@trivikr
Copy link
Contributor

trivikr commented Jan 7, 2025

What version of OpenTelemetry are you using?

CI failure

What version of Node are you using?

CI failure in Node.js

What did you do?

CI failed for #2623 (comment), due to dependency @aws-sdk/client-sqs

What did you expect to see?

CI to run deprecation of AWS SDK for JavaScript v2

What did you see instead?

CI failure because of @aws-sdk/client-sqs dependency, possibly unrelated to PR

@trivikr trivikr added the bug Something isn't working label Jan 7, 2025
@trivikr
Copy link
Contributor Author

trivikr commented Jan 7, 2025

Probably related to the SDK?
aws/aws-sdk-js-v3#6779

@trivikr
Copy link
Contributor Author

trivikr commented Jan 7, 2025

This issue is specific to Node.js 14.x

The error in Node.js 16.x is different https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/12656564146/job/35269729978?pr=2623, and needs to be handled in the PR.

  1) MessageAttributes
       injectPropagationContext
         should inject context if there are available attributes:
     Error: expect(received).toBeGreaterThan(expected)

Expected: > 5
Received:   5
      at Context.<anonymous> (test/MessageAttributes.test.ts:84:53)
      at processImmediate (node:internal/timers:491:21)
      at process.topLevelDomainCallback (node:domain:161:15)
      at process.callbackTrampoline (node:internal/async_hooks:128:24)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant