From d1c89f7afe54e98c6b985ee89e19f3e4d98f4013 Mon Sep 17 00:00:00 2001 From: Amir Blum Date: Sat, 12 Nov 2022 09:18:40 +0200 Subject: [PATCH 1/3] docs: fix comment in metrics api refering to span --- api/src/metrics/Metric.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/src/metrics/Metric.ts b/api/src/metrics/Metric.ts index d0b6909bd7e..c1be59809fa 100644 --- a/api/src/metrics/Metric.ts +++ b/api/src/metrics/Metric.ts @@ -83,7 +83,7 @@ export interface Histogram Date: Sat, 12 Nov 2022 09:38:04 +0200 Subject: [PATCH 2/3] fix(api): deprecate MetricsAttributes and MetricAttributeValue --- api/CHANGELOG.md | 4 ++++ api/src/metrics/Metric.ts | 10 ++-------- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/api/CHANGELOG.md b/api/CHANGELOG.md index 12b33c4e2cc..6ee670c645d 100644 --- a/api/CHANGELOG.md +++ b/api/CHANGELOG.md @@ -2,6 +2,10 @@ All notable changes to this project will be documented in this file. +## Unreleased + +* fix(api): deprecate MetricsAttributes and MetricAttributeValue [#3406](https://github.com/open-telemetry/opentelemetry-js/pull/3406) @blumamir + ## [1.3.0](https://www.github.com/open-telemetry/opentelemetry-js-api/compare/v1.2.0...v1.3.0) * feat(api): merge api-metrics into api [#3374](https://github.com/open-telemetry/opentelemetry-js/pull/3374) @legendecas diff --git a/api/src/metrics/Metric.ts b/api/src/metrics/Metric.ts index c1be59809fa..687369b92f2 100644 --- a/api/src/metrics/Metric.ts +++ b/api/src/metrics/Metric.ts @@ -83,19 +83,13 @@ export interface Histogram Date: Sat, 12 Nov 2022 09:42:50 +0200 Subject: [PATCH 3/3] fix: typo in changelog --- api/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/CHANGELOG.md b/api/CHANGELOG.md index 6ee670c645d..8a05d2afe4b 100644 --- a/api/CHANGELOG.md +++ b/api/CHANGELOG.md @@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file. ## Unreleased -* fix(api): deprecate MetricsAttributes and MetricAttributeValue [#3406](https://github.com/open-telemetry/opentelemetry-js/pull/3406) @blumamir +* fix(api): deprecate MetricAttributes and MetricAttributeValue [#3406](https://github.com/open-telemetry/opentelemetry-js/pull/3406) @blumamir ## [1.3.0](https://www.github.com/open-telemetry/opentelemetry-js-api/compare/v1.2.0...v1.3.0)