Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] review and remove unused and deprecated exports #5172

Open
pichlermarc opened this issue Nov 18, 2024 · 2 comments
Open

[core] review and remove unused and deprecated exports #5172

pichlermarc opened this issue Nov 18, 2024 · 2 comments
Labels
needs:code-contribution This feature/bug is ready to implement pkg:core target:next-major-release This PR targets the next major release (`next` branch) type:feature-tracking A feature with sub-issues that need to be addressed

Comments

@pichlermarc
Copy link
Member

pichlermarc commented Nov 18, 2024

Description

@opentelemetry/core is a package that holds some shared code that's used across many packages in this repository and the contrib repository. The package currently exports a large public API which we should reduce to improve maintainability.

This issue is considered done if the following steps are completed for each of the current exports in index.ts:

  • if an export is deprecated, remove the export
  • if an export is not used in any other package in this repository or in contrib repository, remove the export
  • if an export is used in exactly one package - move its code to that package (do not export it from the package it was moved to)
  • if an export is only used in tests in this repository, extract it to a new private package @opentelemetry/internal-test-utils
  • if an export is only used in tests in the contrib repository, extract it to the contrib test utils package
  • remove any code that becomes unused through this process

Some exports may not fall into any of the above categories but still may be better suited for other packages. For these, please open feature-request issues here and we'll discuss moving them as they come up.

Additional Context

@pichlermarc pichlermarc added feature-request pkg:core needs:refinement This issue needs to be refined/broken apart into sub-issues before implementation target:next-major-release This PR targets the next major release (`next` branch) labels Nov 18, 2024
@SehrishHussain
Copy link

Hi @pichlermarc, is this issue open for contributions?

@pichlermarc
Copy link
Member Author

@SehrishHussain it is open for contributions - if you work on it, please keep PRs scoped to smaller chunks so that it's easier to review 🙂
Examples: #5309, #5308

Please let me now if you start working on it so that we don't duplicate work :)

@pichlermarc pichlermarc added type:feature-tracking A feature with sub-issues that need to be addressed needs:code-contribution This feature/bug is ready to implement and removed needs:refinement This issue needs to be refined/broken apart into sub-issues before implementation feature-request labels Jan 9, 2025
@pichlermarc pichlermarc changed the title [core] review and remove unused exports [core] review and remove unused and deprecated exports Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-contribution This feature/bug is ready to implement pkg:core target:next-major-release This PR targets the next major release (`next` branch) type:feature-tracking A feature with sub-issues that need to be addressed
Projects
None yet
Development

No branches or pull requests

2 participants