Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics instrumentation celery #1159

Closed
Tracked by #1040
srikanthccv opened this issue Jun 21, 2022 · 18 comments · Fixed by #1679
Closed
Tracked by #1040

Metrics instrumentation celery #1159

srikanthccv opened this issue Jun 21, 2022 · 18 comments · Fixed by #1679
Assignees
Labels
feature-request good first issue Good for newcomers help wanted Extra attention is needed metrics

Comments

@srikanthccv
Copy link
Member

Relevant semconv: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/instrumentation/kafka.md

@sanketmehta28
Copy link
Member

Hi Can you assign it to me?

@TheAnshul756
Copy link
Contributor

Hello @sanketmehta28
If you are stuck or have not started working on it yet, can you please assign this to me?
CC @srikanthccv

@levivm
Copy link

levivm commented Sep 1, 2022

Hello @srikanthccv @TheAnshul756 this means that I can't use Opentelemetry Metrics under Celery ? Right now I'm trying to use it but some metrics are getting lost, I assume it's because the normal exporter doesn't work correctly in celery/worker-based projects, right ?

@srikanthccv
Copy link
Member Author

@levivm I didn't understand your question. This issue is for adding metrics instrumentation for opentelemetry-instrumentation-celery. Today it only supports tracing.

@levivm
Copy link

levivm commented Sep 2, 2022

@srikanthccv I want to send metrics not span from a celery worker using OpenTelemetry, but it seems some metrics are getting lost, so, I don't know if it is because OpenTelemetry Metrics is not yet supported to be used along celery ? Thanks in advance for you help.

@srikanthccv
Copy link
Member Author

The celery instrumentation doesn't have metrics instrumentation yet and this is a tracker issue for it.

@TheAnshul756
Copy link
Contributor

Hello @srikanthccv
I wanted to know what metric semantic convention to follow for task queues like Celery?

@srikanthccv
Copy link
Member Author

We will do something similar to this https://flower.readthedocs.io/en/latest/prometheus-integration.html#available-metrics. Since this framework is specific to Python projects it won't probably be added to spec but we can provide these metrics using OTEL Metrics API.

@Akochavi
Copy link
Contributor

Akochavi commented Feb 5, 2023

Hi, can I work on it or you already work on it? @TheAnshul756

@TheAnshul756 TheAnshul756 removed their assignment Feb 6, 2023
@TheAnshul756
Copy link
Contributor

Sure you can work on it.

@Akochavi
Copy link
Contributor

@srikanthccv Hi, I try to add Gauge metrics and I see that there isn't record option for Gauge (For example when I use Histogram, the option is exist).
Do you know if this option exists in some form?
Is there a situation where they didn't implement it until they needed to? Or maybe you don't need to call anything at all and it should work that way?
Because no one has used it before so there is no reference at all.

@srikanthccv
Copy link
Member Author

There is no sync gauge in metric API/SDK specification. However, there is an async gauge. What gauge metrics did you have to add?

@Akochavi
Copy link
Contributor

@srikanthccv

  • Number of tasks currently executing in this worker
  • Number of tasks of given type prefetched at a worker

@srikanthccv
Copy link
Member Author

You can use UpDownCounter?

@Akochavi
Copy link
Contributor

Akochavi commented Mar 1, 2023

I use a histogram, I found it more suitable

@Akochavi
Copy link
Contributor

@srikanthccv Why we don't merge it?
I see that I got approve.

@srikanthccv
Copy link
Member Author

There are unresolved conversations. It will be merged when they are addressed.

@Akochavi
Copy link
Contributor

Akochavi commented May 3, 2023

@srikanthccv All the conversations resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request good first issue Good for newcomers help wanted Extra attention is needed metrics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants