Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OTEL_EXPORTER_*_INSECURE environment variables #1649

Closed
srikanthccv opened this issue Feb 25, 2021 · 3 comments · Fixed by #1682
Closed

Remove OTEL_EXPORTER_*_INSECURE environment variables #1649

srikanthccv opened this issue Feb 25, 2021 · 3 comments · Fixed by #1682
Assignees
@srikanthccv
Labels
1.0.0rc2 release candidate 2 for tracing GA bug Something isn't working

Comments

@srikanthccv
Copy link
Member

We have OTEL_EXPORTER_*_INSECURE to enable exporting telemetry data with insecure channel. The OTLP Config specification https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#configuration-options doesn't have it. The expected behaviour is If the TLS certificate is set with OTEL_EXPORTER_*_CERTIFICATE we need to use ssl_channel_creds other insecure channel.
@srikanthccv srikanthccv added the bug Something isn't working label Feb 25, 2021
@codeboten
Copy link
Contributor

Just to clarify, the secure/insecure behaviour is a result of the protocol set in the Endpoint configuration

@codeboten codeboten added the 1.0.0rc2 release candidate 2 for tracing GA label Mar 4, 2021
@srikanthccv
Copy link
Member Author

@codeboten Just noticed this is added to RC2. I will work on this.

@srikanthccv
Copy link
Member Author

I was working on this and have a small question. If OTEL_EXPORTER_*_CERTIFICATE is not set, then should we let gRPC runtime to pick the default location with ssl_channel_credentials() or use the insecure_channel?

@srikanthccv srikanthccv mentioned this issue Mar 9, 2021
Merged
@alexmojaki alexmojaki mentioned this issue May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanthccv srikanthccv

Labels
1.0.0rc2 release candidate 2 for tracing GA bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@codeboten @srikanthccv