Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current schema version should be excluded from schema_check validation #2934

Closed
lmolkova opened this issue Nov 9, 2022 · 2 comments
Closed
Assignees
Labels
spec:miscellaneous For issues that don't match any other spec label

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Nov 9, 2022

What are you trying to achieve?
I'm trying to rename some attributes and add schema mapping here https://github.com/open-telemetry/opentelemetry-specification/pull/2763/files#diff-13146afa870e358cc26b1d9a83dbf7aa95e784b6042c04e104ff22b7ad4844be

It fails since I'm changing 1.15 and it does not match the published one.

What did you expect to see?

I should be able to add new attribute renames for current schema version in the PR

Additional context.
The check was introduced in #2868

@lmolkova lmolkova added the spec:miscellaneous For issues that don't match any other spec label label Nov 9, 2022
@arminru
Copy link
Member

arminru commented Nov 14, 2022

@lmolkova Did you close this on purpose or should it be re-opened?
I think it should work if you just use the "expected" next version (1.16.0 in this case) in the PR.

@lmolkova
Copy link
Contributor Author

@arminru thank you! I realized that 1.15 was already released and I needed to create 1.16.0 file, so I closed it on purpose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Development

No branches or pull requests

3 participants