Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ED-PIC: Remove proton/neutron Number? #191

Open
ax3l opened this issue Apr 3, 2018 · 3 comments
Open

ED-PIC: Remove proton/neutron Number? #191

ax3l opened this issue Apr 3, 2018 · 3 comments
Assignees
Labels
EXT: ED-PIC electro-magnetic particle-in-cell extrension EXT: SpeciesType physical particle species extension
Milestone

Comments

@ax3l
Copy link
Member

ax3l commented Apr 3, 2018

With the new speciesType attribute in an extension #180, we can remove (and auto-update) the optional protonNumber and neutronNumber attribute in the ED-PIC extension.

@ax3l ax3l added EXT: ED-PIC electro-magnetic particle-in-cell extrension EXT: SpeciesType physical particle species extension labels Apr 3, 2018
@ax3l ax3l added this to the openPMD 2.X milestone Apr 3, 2018
@RemiLehe
Copy link
Member

RemiLehe commented Apr 3, 2018

I agree.

@DavidSagan
Copy link
Collaborator

And I too agree

@RemiLehe RemiLehe self-assigned this Apr 3, 2018
@RemiLehe
Copy link
Member

RemiLehe commented Apr 3, 2018

I can do a PR on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EXT: ED-PIC electro-magnetic particle-in-cell extrension EXT: SpeciesType physical particle species extension
Projects
Status: Review
Development

No branches or pull requests

3 participants