Support Python virtual envs with OSC Plugins

[crazyscientist]

The function for loading plugins looks exclusively in 4 directories. This has multiple disadvantages:

• Using plugins with different Python versions
• OSC plugins are ripped out of the Python libraries

So I propose:

1. osc_plugins to be a proper Python module/package
2. Discovery and import of plugins to honor Python's import/discovery mechanism

[marcus-h]

On 2020-03-06 04:56:36 -0800, Andreas Hasenkopf wrote: The function for loading plugins looks exclusively in 4 directories. This has multiple disadvantages: - Using plugins with different Python versions

Agreed.

- OSC plugins are ripped out of the Python libraries

You just need to "rip out" the UI part or UI "helpers", which delegate to the real implementations (which can reside in a package etc.).

So I propose: 1. `osc_plugins` to be a proper Python module/package 2. Discovery and import of plugins to honor Python's import/discovery mechanism

Yes, we could do that (that's what osc2 is also doing [1] [2]). The question is, if we should provide a proper plugin API for plugins that are provided via an extension point (instead of using the "old", hacky plugin mechanism...). [1] https://github.com/openSUSE/osc2/blob/master/osc2/cli/plugin.py [2] https://lizards.opensuse.org/2012/08/07/gsoc-osc2-client-summary-of-week-11/

[crazyscientist]

I see you like my proposal. If you ask me "proper or old/hacky", I'd choose "proper" 😉

[crazyscientist]

I would like to raise the priority on this issue.

With the introduction of the class-based commands (see 26a8fb1) , osc in a virtualenv cannot load plugins!