osr sr -d in a project directory directly creates submit requests

[andreasstieger]

I created a branch project with two packages, based on packages in the same source project, using "osc bco" each.

I modified each package and committed. I went ahead and created a submit request on one package to the parent project.

I issues "osc sr -d" in the directory containing the branch project. I expected a) the project diff or b) the message that this was not yet supported. Instead, submit requests for both packages were issued. This violated the rule of least surprise.

In addition, a submit request was issued when the same one already existed.

[marcus-h]

On 2013-05-02 13:08:34 -0700, andreasstieger wrote:

I created a branch project with two packages, based on packages in the same source project, using "osc bco" each.

I modified each package and committed. I went ahead and created a submit request on one package to the parent project.

I issues "osc sr -d" in the directory containing the branch project. I expected a) the project diff or b) the message that this was not yet supported. Instead, submit requests for both packages were issued. This violated the rule of least surprise.

Fixed in commit 6915004.

In addition, a submit request was issued when the same one already existed.

Hmm what do you exactly mean? Should osc check for each package if there
are existing submitrequests and if so offer the possibility to supersede
them?

[andreasstieger]

I think in the last case it should behave like it does when submitting packages. I believe there is no automatic superseding for package submit requests, and they are not cancelled, so this wouldn't be required. So with the commit I think this is closed for me.

[lethliel]

Ok. So we can close this now.