Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in the FourRooms env implementation #15

Open
ankeshanand opened this issue Jun 24, 2018 · 0 comments
Open

Bug in the FourRooms env implementation #15

ankeshanand opened this issue Jun 24, 2018 · 0 comments

Comments

@ankeshanand
Copy link

It seems the code for the FourRooms env was carried over from the option-critic implementation, and thus it also has a bug that the option-critic implementation had. See: jeanharb/option_critic#11

Also, it seems that the goal is same every episode? https://github.com/openai/mlsh/blob/master/test_envs/test_envs/envs/fourrooms.py#L60

@kvfrans It would be cool if you can clarify this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ankeshanand