Sdk automation script #585
Conversation
eng/scripts/Sdk-Generate.ps1
Outdated
| if($line -match "[\/][0-9a-f]{4,40}[\/]$inputFile") | ||
| { | ||
| # replacing sha | ||
| $line = $line -replace "[\/][0-9a-f]{4,40}[\/]$inputFile", "/$headSha/$inputFile" |
There was a problem hiding this comment.
If we ever end up allowing branches or tags we might need to update this regex.
eng/scripts/Sdk-Generate.ps1
Outdated
| $readmeMd = @() | ||
| if($packageName -match "Azure.ResourceManager") | ||
| { | ||
| $readmeMd += $name -match "resource-plane" |
There was a problem hiding this comment.
These path names might not be something we should rely on. Don't we know which readme's based on the matching input files in the readmes?
There was a problem hiding this comment.
I've updated the script and added readme's based on the matching readme input files but now in order to add readme path in output json, it expects readme.md as an input file in autorest.md. Currently for few SDKs we use directly spec(json file) as an input file. I have already created an issue to use readmes in autorest.md.
eng/scripts/Sdk-Generate.ps1
Outdated
|
|
||
| $downloadUrlPrefix = $input.installInstructionInput.downloadUrlPrefix | ||
| $installInstructions = [PSCustomObject]@{ | ||
| full = "Download the $packageName from [here]($downloadUrlPrefix)" |
There was a problem hiding this comment.
I'm not sure that link will work so we should test to see what it does. I was expecting we would need to add the package name to the download line as well to get this link to be useful.
There was a problem hiding this comment.
Yes it should be prefix + filename
ShivangiReja
force-pushed
the
SDK_AutomationScript
branch
from
ba1c508 to
0bd382c
Compare
eng/scripts/dotnet-install.ps1
Outdated
| @@ -0,0 +1,976 @@ | |||
| # | |||
There was a problem hiding this comment.
Do we need to check-in this entire script? Or should we use the well known version, similar to what the .NET team does, see https://github.com/dotnet/runtime/blob/master/eng/common/tools.ps1#L193 as an example.
It might also be better to read the version from the global.json file similar to what they do in as well https://github.com/dotnet/runtime/blob/master/eng/common/tools.ps1#L140.
There was a problem hiding this comment.
Ahh, that's nice! Thanks for the suggestion.
azure-sdk
force-pushed
the
master
branch
5 times, most recently
from
6498326 to
25e7298
Compare
|
Hi @weshaggard, when I was creating this PR I thought I'll move this PR to azure-sdk-for-net repo once I'll do the cleanup but now I'm not able to change the base repo as Please review and give further feedback here. Sorry for all the inconvenience. |
For reference please checkout the generateOutput.json here