Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minted 2 CI #64

Open
alexarice opened this issue Feb 5, 2025 · 4 comments · May be fixed by #66
Open

Minted 2 CI #64

alexarice opened this issue Feb 5, 2025 · 4 comments · May be fixed by #66
Assignees
Labels
enhancement New feature or request

Comments

@alexarice
Copy link
Contributor

We seem to have a CI for the latest latex version on minted 3, and a CI for "old minted" (not sure exactly which version). I wonder if it would be worth adding a new ci with latex pinned to a few months ago to hit the newer minted 2 version

@compor
Copy link
Contributor

compor commented Feb 6, 2025

I'll check which version the *_old.yml CI flow is using and get back to you.

@compor compor self-assigned this Feb 6, 2025
@compor compor added the enhancement New feature or request label Feb 6, 2025
@compor
Copy link
Contributor

compor commented Feb 11, 2025

So,

  1. build_paper_old.yml using the TeXLive image tagged ghcr.io/xu-cheng/texlive-full:20221101 uses minted v2.6
  2. The last version before minted v3 is minted v2.9 and the last TeXLive image to include it is ghcr.io/xu-cheng/texlive-full:20240901
  3. From then onward, the images use minted v3+

These correspond to the macros we have currently in the template; with the first two resolving this issue that appeared on v2.7.

Ubuntu LTS release 22.04 (Jammy) uses a TeXLive distro with minted v2.6 still.

Hence, I'm inclined to keep the old workflow for now.
The question is if we want to add to it another one with the last minted version 2 released (v2.9).

@alexarice
Copy link
Contributor Author

I hit an error where V2.9 didn't work with my paper with Ci being green, so would personally vote for having all 3 in ci

@compor
Copy link
Contributor

compor commented Feb 11, 2025

I see; then people can edit/disable at will on their forks.

@compor compor linked a pull request Feb 12, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants